Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37767 )
Change subject: util/inteltool: drop OS-specific rdmsr/wrmsr prototypes
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37767/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37767/4//COMMIT_MSG@7
PS4, Line 7: rdmsr functions
nit: rdmsr/wrmsr prototypes
Done
https://review.coreboot.org/c/coreboot/+/37767/4//COMMIT_MSG@9
PS4, Line 9: Tested on: FreeBSD 13.0-CURRENT r355582
This should go after the commit message.
Done
https://review.coreboot.org/c/coreboot/+/37767/4//COMMIT_MSG@12
PS4, Line 12:
Maybe add that these prototypes need to be removed since that commit made rdmsr static. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37767
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aba72f39b528fd70451a4656fd6c835ff766e49
Gerrit-Change-Number: 37767
Gerrit-PatchSet: 5
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jan 2020 14:50:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment