Attention is currently required from: Furquan Shaikh, Martin Roth, Duncan Laurie. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52747 )
Change subject: util/sconfig: Add support for discontiguous FW_CONFIG fields ......................................................................
Patch Set 5:
(44 comments)
File util/sconfig/lex.yy.c_shipped:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/e97b814f_9969dece PS5, Line 34: * if you want the limit (max/min) macros for int types. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/6d89832e_2b21926a PS5, Line 51: typedef unsigned char flex_uint8_t; trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/4f12ab22_022bb829 PS5, Line 162: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/15fdbcfd_7601245c PS5, Line 165: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/14346d9a_8ffc8b81 PS5, Line 641: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/4f97a4ab_8a3ceee4 PS5, Line 643: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/5d527105_9f3fea71 PS5, Line 770: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/75a1b7f7_0a2b05b2 PS5, Line 1344: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/435abf8d_91aeb031 PS5, Line 1400: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/fd5c9d56_f9da3d56 PS5, Line 1445: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/53c307ea_846d7860 PS5, Line 1512: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/57be3a48_aa3c937d PS5, Line 1517: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/c3ed08ed_cd46cdd3 PS5, Line 1530: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/5b564e6c_e28eeaf2 PS5, Line 1534: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/9ca4552b_527803c2 PS5, Line 1574: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/b35c4f00_2240b032 PS5, Line 1580: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/cfda1534_bb88a961 PS5, Line 1603: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/5d8ee6e4_94a0c38a PS5, Line 1607: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/53e18a63_19d61976 PS5, Line 1628: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/3595152e_5c3268c5 PS5, Line 1644: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/9a802c88_6fef917d PS5, Line 1650: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/3a2e7f4e_52a3cdc1 PS5, Line 1679: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/3b1116ca_70c03468 PS5, Line 1709: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/8eeac759_95f6351f PS5, Line 1733: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/b0a14d7f_48f71416 PS5, Line 1776: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/a2d4180c_81edc98a PS5, Line 1782: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/967a55b4_d93edc5f PS5, Line 1811: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/851ff076_4fe549d2 PS5, Line 1818: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/be2e0bde_3c8dd52a PS5, Line 1826: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/eeefa360_a72065b3 PS5, Line 1835: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/d41e7f4b_9a4ed215 PS5, Line 1889: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/068719c9_e259ce11 PS5, Line 1893: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/384ece45_3317872e PS5, Line 1898: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/1d2737f8_7aae7f10 PS5, Line 1906: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/220ccb10_a9936897 PS5, Line 1914: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/3dd82cbf_c1a4dad0 PS5, Line 1922: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/d1029519_a2b90170 PS5, Line 1932: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/0ab5e78c_2436ec7b PS5, Line 1936: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/ea7100e3_b4fab405 PS5, Line 1943: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/e361988f_e4f7cf74 PS5, Line 1997: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/dfc0c56d_4a6cc2c9 PS5, Line 2023: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/47562d63_e6559e32 PS5, Line 2048: trailing whitespace
File util/sconfig/main.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/0624ed93_1ad7a1f1 PS5, Line 453: printf("ERROR: fw_config field %s has invalid range %u-%u\n", field->name, line over 96 characters
File util/sconfig/sconfig.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118130): https://review.coreboot.org/c/coreboot/+/52747/comment/8b7c0869_20087a52 PS5, Line 223: struct fw_config_field *new_fw_config_field(const char *name, struct fw_config_field_bits *bits); line over 96 characters