Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46884 )
Change subject: drivers/intel/fsp2_0: Add function to report FSP-T output
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46884/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S:
https://review.coreboot.org/c/coreboot/+/46884/1/src/soc/intel/common/block/...
PS1, Line 75: push %ecx
: push %edx
This is pushed on the stack instead of directly writing the variables as bss is cleared below. Is that clear or does it deserve a comment?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d79f97f8c12c63ce215935353717855442a8290
Gerrit-Change-Number: 46884
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 28 Oct 2020 14:14:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment