Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31727 )
Change subject: util/amdfwtool: Clarify calculations with structures ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31727/2/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/31727/2/util/amdfwtool/amdfwtool.c@a786 PS2, Line 786:
Was this just a reserved byte?
No. Offset 0x8 is a 64-bit address (i.e. the +2 and +3 dwords here). The original code loads the lower 32 bits and zeroes the upper. These two assignments are replaced by the single ".lvl2_addr =" in PS2.
https://review.coreboot.org/#/c/31727/2/util/amdfwtool/amdfwtool.c@a796 PS2, Line 796:
Maybe fix it up in a follow on?
I'll say follow on. It bugs me mostly because it goes >80 now, but I'm trying not to do much w/combo except make sure it works. ...had considered removing it, but that seems a shame. I'm surprised the 1002 0b00 ID works on ST; I'm pretty sure that doesn't match.