Name of user not set #1002789 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38722 )
Change subject: nb/intel/haswell: Fix type definition of dev in PCI_FUNC(dev) ......................................................................
Patch Set 2:
(3 comments)
Patch Set 1: Code-Review+1
(3 comments)
Comments fixed.
https://review.coreboot.org/c/coreboot/+/38722/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38722/1//COMMIT_MSG@7 PS1, Line 7: src/northbridge/intel/haswell/early_init.c: Fix type definition of dev in PCI_FUNC(dev)
You can drop some boilerplate here, the prefix doesn't have to be a […]
Fixed
https://review.coreboot.org/c/coreboot/+/38722/1//COMMIT_MSG@10 PS1, Line 10: function
technically, it's a macro, not a function
Updated commit message.
https://review.coreboot.org/c/coreboot/+/38722/1//COMMIT_MSG@11 PS1, Line 11: Will submit subsequent patches to enable dGPU.
Please break lines before 72 chars.
Ack