Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44156 )
Change subject: mb/google/zork: Add kconfigs to check schematic version 3.6
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44156/3/src/mainboard/google/zork/K...
File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/44156/3/src/mainboard/google/zork/K...
PS3, Line 180: default y if BOARD_GOOGLE_VILBOZ
You are going to need BOARD_GOOGLE_DIRINBOZ as well here and for VARIANT_MIN_BOARD_ID_V3_6_SCHEMATICS
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44156
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If86e1ea3c02db354c7b410f1bbc1daacb483cc51
Gerrit-Change-Number: 44156
Gerrit-PatchSet: 3
Gerrit-Owner: Josie Nordrum
josienordrum@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 00:25:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment