[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso/sb: Gate FCH AL2AHB clocks

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42829 )

Change subject: soc/amd/picasso/sb: Gate FCH AL2AHB clocks
......................................................................

Patch Set 6: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/42829/4/src/soc/amd/picasso/southbr... 
File src/soc/amd/picasso/southbridge.c:

https://review.coreboot.org/c/coreboot/+/42829/4/src/soc/amd/picasso/southbr... 
PS4, Line 339: 	al2ahb_val = read8((void *)(AL2AHB_BASE + AL2AHB_CONTROL_CLK_OFFSET));
> Check the latest patch to make sure I did it right. […]

It's fine now. In short it's an issue of literals defaulting to ints in C. It's to handle lp64  (longs pointers are 64-bit) vs ilp32 (integers longs pointers are 32-bit). For forward pointing code uintptr_t is the size of a pointer for unsigned int. Therefore it will work regardless of pointer size.

UEFI likes to use UINTN for posix type uintptr_t from my recollection.