Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21107 )
Change subject: sb,soc/intel: Fix flashconsole on older architectures
......................................................................
Patch Set 14: Code-Review-1
(3 comments)
https://review.coreboot.org/#/c/21107/14//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/21107/14//COMMIT_MSG@12
PS14, Line 12: build/romstage/drivers/spi/spi-generic.o: In function `spi_setup_slave':
I don't have this error at master
https://review.coreboot.org/#/c/21107/14//COMMIT_MSG@17
PS14, Line 17: This is due to the fact that sb/intel/common/spi.c is currently not built
not true
https://review.coreboot.org/#/c/21107/14/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/#/c/21107/14/src/southbridge/intel/common/spi.c@...
PS14, Line 19: #include <arch/early_variables.h>
why?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/21107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd3e8621fa4cb349b7e0e07118cab0380f24ff55
Gerrit-Change-Number: 21107
Gerrit-PatchSet: 14
Gerrit-Owner: Nicola Corna
nicola@corna.info
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nicola Corna
nicola@corna.info
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 15 May 2019 11:48:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment