Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/25432 )
Change subject: soc/intel/denverton_ns: Use cpulib in cpu.c ......................................................................
soc/intel/denverton_ns: Use cpulib in cpu.c
Also remove duplicate code
Change-Id: I45da6363a35cf6f5855906bb97ed023681d36df7 Signed-off-by: Julien Viard de Galbert jviarddegalbert@online.net Reviewed-on: https://review.coreboot.org/c/25432 Reviewed-by: Vanny E vanessa.f.eusebio@intel.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: David Guckian Reviewed-by: Jay Talbott JayTalbott@sysproconsulting.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/denverton_ns/cpu.c 1 file changed, 1 insertion(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Vanny E: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Jay Talbott: Looks good to me, but someone else must approve David Guckian: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/denverton_ns/cpu.c b/src/soc/intel/denverton_ns/cpu.c index f954411..b3a12c5 100644 --- a/src/soc/intel/denverton_ns/cpu.c +++ b/src/soc/intel/denverton_ns/cpu.c @@ -24,6 +24,7 @@ #include <cpu/intel/turbo.h> #include <device/device.h> #include <device/pci.h> +#include <intelblocks/cpulib.h> #include <reg_script.h>
#include <soc/msr.h> @@ -175,15 +176,6 @@ return num_cpus; }
-static int cpu_config_tdp_levels(void) -{ - msr_t platform_info; - - /* Bits 34:33 indicate how many levels supported */ - platform_info = rdmsr(MSR_PLATFORM_INFO); - return (platform_info.hi >> 1) & 3; -} - static void set_max_turbo_freq(void) { msr_t msr, perf_ctl;