Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42829 )
Change subject: soc/amd/picasso/sb: Gate FCH AL2AHB clocks
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42829/4/src/soc/amd/picasso/southbr...
File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/c/coreboot/+/42829/4/src/soc/amd/picasso/southbr...
PS4, Line 339: al2ahb_val = read8((void *)(AL2AHB_BASE + AL2AHB_CONTROL_CLK_OFFSET));
please cast through uintptr_t
You probably wanta local variable dealing with the base to use to add offsets.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcbc144a8769f8ea440cdd560bab146bf5058cf9
Gerrit-Change-Number: 42829
Gerrit-PatchSet: 4
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jun 2020 14:39:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment