Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28724 )
Change subject: commonlib/region: Add region protect API ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/28724/2/src/commonlib/include/commonlib/regi... File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/#/c/28724/2/src/commonlib/include/commonlib/regi... PS2, Line 67: * Returns < 0 on error otherwise returns 0 on success, < 0 0n error. copy paste error ?
https://review.coreboot.org/#/c/28724/2/src/commonlib/region.c File src/commonlib/region.c:
https://review.coreboot.org/#/c/28724/2/src/commonlib/region.c@154 PS2, Line 154: int rdev_protect(const struct region_device *rd) please mention in a comment that it'll make the flash write protected