Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: convert SGX and PRMRR devicetree options to Kconfig
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35799/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35799/7//COMMIT_MSG@9
PS7, Line 9: nod
not
https://review.coreboot.org/c/coreboot/+/35799/7//COMMIT_MSG@19
PS7, Line 19: extendend
extended
https://review.coreboot.org/c/coreboot/+/35799/7/src/soc/intel/apollolake/me...
File src/soc/intel/apollolake/memmap.c:
https://review.coreboot.org/c/coreboot/+/35799/7/src/soc/intel/apollolake/me...
PS7, Line 53: */
Please use one of the recommended multi-line comment styles.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f08e85898304bba6680075ca5d6bce26aef9a4d
Gerrit-Change-Number: 35799
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Oct 2019 09:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment