Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38700 )
Change subject: drivers/intel/fsp2_0: Add callback after non-XIP FSP-M load
......................................................................
Patch Set 6:
After talking to Nico on IRC it finally became clear what his point is here: The memory reservation should be done in the FSP driver and not the Picasso SoC code, since it's not specific to Picasso, but to the (non-XIP & non-CAR) FSP-M case. Not sure if it would be better to rework this now or fix it later, but before the next platform will land
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04b2fff4074b720d1910ff21e1a1f841cfea8efb
Gerrit-Change-Number: 38700
Gerrit-PatchSet: 6
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Apr 2020 17:23:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment