Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38370 )
Change subject: rtc/post.c: Fix compilation issue for post.c
......................................................................
Patch Set 2:
Patch Set 1:
Please add test configuration for the feature.
CMOS uses a split IO transaction, I doubt if there is a backup/restore implemented for the related IO index address, so it's not really safe to call cmos_post_code from SMM context, I would prefer adding !ENV_SMM at the call-site.
I have updated patchset with suggestion
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffdcccaad48e7ad96e068d07046630fbe4297e65
Gerrit-Change-Number: 38370
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 Jan 2020 16:07:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment