Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36696 )
Change subject: arch/x86/car.ld: Use REGION macro
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36696/1/src/arch/x86/car.ld
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/36696/1/src/arch/x86/car.ld@38
PS1, Line 38: .,
SGTM, that would be a bit more consistent with the other archs.
The stack is in a different location for CAR stages (linker symbol), postcar (set up in postcar frame) and ramstage (in .bss), which could be confusing. Is it always at the same location in SRAM for ARM?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36696
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c327343eb40d3e2cc8513354ec3a83d803ff1ee
Gerrit-Change-Number: 36696
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Tue, 12 Nov 2019 22:22:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment