EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35023 )
Change subject: libpayload/usb: add USB 3.1 GEN2 support
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/drivers...
File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/drivers...
PS2, Line 701: int is_usb_speed_ss(usb_speed speed)
: {
: if (speed == SUPER_SPEED || speed == SUPER_SPEED_PLUS)
: return 1;
: return 0;
: }
Sorry to be a pain, but you can use a bool here. […]
I want this be a little flexible. If we have GNE3 or 4 in the future? I am okay with your comment as well. Any idea?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0ef12b2f0d91bf0d0db766bbc9019de1614a4f4
Gerrit-Change-Number: 35023
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 23 Aug 2019 16:48:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment
