Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30742 )
Change subject: vendorcode/intel/fsp1_0/broadwell_de: Use FSP from 3rdparty/fsp
......................................................................
Patch Set 6: Code-Review+1
After reviewing the changes further, I can see how we could adapt to this change in the future using our custom built FSP. Not ideal, but it won't block us. I know we have a very atypical use case, so our requirements and needs don't always align with the overall community. Now that I've worked through it, I can give this a +1, as I can see the value for the more common use case.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30742
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f201218d19cf34c43a04f57458f474d8c3340d
Gerrit-Change-Number: 30742
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 13 Jan 2019 15:06:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment