build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35159 )
Change subject: google/kukui: Load calibration result and run fast-calibration ......................................................................
Patch Set 2:
(22 comments)
https://review.coreboot.org/c/coreboot/+/35159/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35159/2/src/mainboard/google/kukui/... PS2, Line 73: /* only can get one freq on times ??? How can we transfer params to mt_mem_init for 3 freq?? */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 937: (dly_coarse_large_rodt_p1 << 4) | (dly_coarse_large_rodt_p1 << 12) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 938: (dly_coarse_large_rodt_p1 << 20) | (dly_coarse_large_rodt_p1 << 28)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 943: (dly_coarse_0p5t_rodt_p1 << 4) | (dly_coarse_0p5t_rodt_p1 << 12) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 944: (dly_coarse_0p5t_rodt_p1 << 20) | (dly_coarse_0p5t_rodt_p1 << 28)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 946: for (u8 dly_fine_xt = 0; dly_fine_xt < DQS_GW_FINE_END; dly_fine_xt += 4) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 990: dly_coarse_large, dly_coarse_0p5t, pass_begin, pass_count, line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1580: vref_dly[index].win_center = params->tx_win_center[chn][rank][index]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1581: vref_dly[index].best_first = params->tx_first_pass[chn][rank][index]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1582: vref_dly[index].best_last = params->tx_last_pass[chn][rank][index]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1593: center_dly[byte].min_center = vref_dly[index].win_center; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1595: center_dly[byte].max_center = vref_dly[index].win_center; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1723: vref_begin = params ->rx_vref[chn]; spaces prohibited around that '->' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1727: vref_begin = params ->tx_vref[chn][rank]; spaces prohibited around that '->' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1753: ((type == TX_WIN_DQ_ONLY) ||(type == TX_WIN_DQ_DQM))) { spaces required around that '||' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1754: dramc_set_tx_best_dly(chn, rank, bypass_tx,vref_dly.perbit_dly, type, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1792: if ( (params->have_full_k_params) && ((type == RX_WIN_RD_DQC) ||(type == RX_WIN_TEST_ENG))) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1792: if ( (params->have_full_k_params) && ((type == RX_WIN_RD_DQC) ||(type == RX_WIN_TEST_ENG))) { spaces required around that '||' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1792: if ( (params->have_full_k_params) && ((type == RX_WIN_RD_DQC) ||(type == RX_WIN_TEST_ENG))) { space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1795: win_perbit[bit].best_first = params->rx_firspass[chn][rank][bit]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1809: /* pass window bigger than 7, consider as real pass window */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/35159/2/src/soc/mediatek/mt8183/dra... PS2, Line 1837: if (dramk_calc_best_vref(type, vref_use, &vref_dly, win_perbit, &win_min_max)) line over 96 characters