10 Dec
2019
10 Dec
'19
3:37 a.m.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37594 )
Change subject: libpayload/drivers/i8042: Add AT translated Keyboard support ......................................................................
Patch Set 2:
Patch Set 2:
(1 comment)
I am not opposed to this change, however we need to be careful to not break Chromium ToT by removing the IGNORE_INIT_FAILURE flag. We should add the new flag and migrate to it before removing the old flag. Also have you verified that all keys work as expected in depthcharge including F12 and the arrow keys?
I can test it with Asset ID and diag mode.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37594
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1053e24e44c5bad28b56cc92d091e24f3d9b6fd
Gerrit-Change-Number: 37594
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Dec 2019 03:37:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment