[coreboot-gerrit] Change in coreboot[master]: amdfwtool: Get size and location of BIOSBIN

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46092 )

Change subject: amdfwtool: Get size and location of BIOSBIN
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46092/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46092/1//COMMIT_MSG@7 
PS1, Line 7: amdfwtool
Change to
  soc/amd/picasso: Use readelf to find bootblock size and location

https://review.coreboot.org/c/coreboot/+/46092/1/src/soc/amd/picasso/Makefil... 
File src/soc/amd/picasso/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/46092/1/src/soc/amd/picasso/Makefil... 
PS1, Line 212: # This address must match the BOOTBLOCK logic in arch/x86/memlayout.ld.
This comment may be uninteresting now, so maybe remove it.  Since we're getting the info from the elf file, it should be guaranteed to match memlayout.ld.