Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36650 )
Change subject: soc/intel/skylake: Improve comment for DISB ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36650/1/src/soc/intel/skylake/pmc.c File src/soc/intel/skylake/pmc.c:
https://review.coreboot.org/c/coreboot/+/36650/1/src/soc/intel/skylake/pmc.c... PS1, Line 35: * Set the DISB after DRAM init. Dot at the end not needed.
https://review.coreboot.org/c/coreboot/+/36650/1/src/soc/intel/skylake/pmc.c... PS1, Line 43: */ Maybe add it as the function description, so above `pmc_set_disb()`?