Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34990 )
Change subject: mediatek/mt8183: Use different DRAM frequencies for eMCP DDR ......................................................................
Patch Set 33:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34990/32/src/soc/mediatek/mt8183/em... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/34990/32/src/soc/mediatek/mt8183/em... PS32, Line 22: ic const u8 const freq_shuffle[DRAM_DFS_SHUFFLE_MAX] = { : [DRAM_DFS_SHUFFLE_1] = LP4X_DDR3200, : [DRAM_DFS_SHUFFLE_2] = LP4X_DDR2400, : [DRAM_DFS_SHUFFLE_3] = LP4X_DDR1600, : }; : static const u8 const freq_shuffle_emcp[DRAM_DFS_SHUFFLE_MAX] = { : [DRAM_DFS_SHUFFLE_1] = LP4X_DDR3600, : [DRAM_DFS_SHUFFLE_2] = LP4X_DDR3200, : [DRAM_DFS_SHUFFLE_3] = LP4X_DDR1600, : };
I think those change will make code mess at patch https://review.coreboot. […]
How about this:
u8 *freq_tbl; if (CONFIG(MT8183_DRAM_EMCP)) freq_tbl = freq_shuffle_emcp; else freq_tbl = freq_shuffle;
Then the following lines don't need to be changed.