Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30939 )
Change subject: nb/intel/pineview: Move to C_ENVIRONMENT_BOOTBLOCK ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30939/2/src/mainboard/foxconn/d41s/bootblock... File src/mainboard/foxconn/d41s/bootblock.c:
https://review.coreboot.org/#/c/30939/2/src/mainboard/foxconn/d41s/bootblock... PS2, Line 36: | COMA_LPC_EN);
I think we should document how much of LPC configuration is to be done in bootblock and whether use […]
I don't think it is the case here, but in general you might end up needing to link more than you want in the bootblock just to get a common early_ file to compile even if it does not end up in the binary.
https://review.coreboot.org/#/c/30939/2/src/mainboard/foxconn/d41s/romstage.... File src/mainboard/foxconn/d41s/romstage.c:
https://review.coreboot.org/#/c/30939/2/src/mainboard/foxconn/d41s/romstage.... PS2, Line 27:
Speculations, do we want to redo this in romstage? Or complete a minimal configuration (from bootblo […]
Any downside to enable all default LPC decode ranges in a common place? Haswell does that.
The GENx_DEC should be done using the devicetree probably romstage since some boards set up things like SIO/FANs with it.