Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39454 )
Change subject: soc/intel/cannonlake: Steal no memory for disabled IGD ......................................................................
Patch Set 17:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39454/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39454/16//COMMIT_MSG@12 PS16, Line 12: panel
panel *power*
Ack
https://review.coreboot.org/c/coreboot/+/39454/16//COMMIT_MSG@15 PS16, Line 15: Also apply a workaround to prevent a crash, see : https://github.com/IntelFsp/FSP/issues/49 : for details.
Maybe word it this way: […]
Ack
https://review.coreboot.org/c/coreboot/+/39454/16/src/soc/intel/cannonlake/r... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39454/16/src/soc/intel/cannonlake/r... PS16, Line 30: power panel
"panel power" ?
Ack