Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44343 )
Change subject: mb/google/zork: Add variant.c to align with dalboz reference board
......................................................................
Patch Set 1:
Patch Set 1:
Kevin, do you need all the logic in variant.c? Or was this copy/pasted?
Hi Aaron,
it was just copied from dalboz as the initialization. thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dffdf5654680e3c2c0b259ee82a471f8ff14f56
Gerrit-Change-Number: 44343
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 11 Aug 2020 02:32:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment