John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39785 )
Change subject: soc/intel/tigerlake: Configure TCSS power management
......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39785/20/src/soc/intel/tigerlake/ac...
File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/39785/20/src/soc/intel/tigerlake/ac...
PS20, Line 47:
: /*
: * Define PCH ACPIBASE I/O as an ACPI operating region. The base address can be
: * found in Device 31, Function 2, Offset 40h.
: */
: OperationRegion (PMIO, SystemIO, PCH_PWRM_BASE_ADDRESS, 0x80)
: Field (PMIO, ByteAcc, NoLock, Preserve) {
: Offset(0x6C), /* 0x6C, General Purpose Event 0 Status [127:96] */
: , 19,
: CPWS, 1, /* CPU WAKE STATUS */
: Offset(0x7C), /* 0x7C, General Purpose Event 0 Enable [127:96] */
: , 19,
: CPWE, 1 /* CPU WAKE EN */
: }
tab indent
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39785
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I127d3700ad426a44639ee93b4477be6638b42e1b
Gerrit-Change-Number: 39785
Gerrit-PatchSet: 20
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Apr 2020 17:15:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment