Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33423 )
Change subject: mainboard/facebook/fbg1701/fadt.c: Use asl_revision ......................................................................
mainboard/facebook/fbg1701/fadt.c: Use asl_revision
Fix value of 1 is used for asl_compiler_revision. Use asl_revision for this.
BUG=N/A TEST=booting Linux 4.20 kernel on Facebook FBG1701
Change-Id: Iffd8fe637d4669b7099fb6eafc9873560502bf80 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33423 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Lance Zhao lance.zhao@gmail.com --- M src/mainboard/facebook/fbg1701/fadt.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Lance Zhao: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/fadt.c b/src/mainboard/facebook/fbg1701/fadt.c index 60dd5b9..544d24b 100644 --- a/src/mainboard/facebook/fbg1701/fadt.c +++ b/src/mainboard/facebook/fbg1701/fadt.c @@ -16,6 +16,7 @@ */
#include <soc/acpi.h> +#include <version.h>
void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) { @@ -28,7 +29,7 @@ memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); - header->asl_compiler_revision = 1; + header->asl_compiler_revision = asl_revision;
fadt->firmware_ctrl = (unsigned long) facs; fadt->dsdt = (unsigned long) dsdt;