Attention is currently required from: Paul Menzel, Shelley Chen.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78009?usp=email )
Change subject: mb/google/brox: Create new Brox baseboard ......................................................................
Patch Set 8:
(4 comments)
File src/mainboard/google/brox/variants/brox/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/78009/comment/56968d53_6b58af81 : PS5, Line 7: SPD_SOURCES += spd/lp4x/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:F, H9HCNNNBKMMLXR-NEE, MT53E512M32D1NP-046 WT:B : SPD_SOURCES += spd/lp4x/set-0/spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A : SPD_SOURCES += spd/lp4x/set-0/spd-7.hex # ID = 2(0b0010) Parts = MT53E2G32D4NQ-046 WT:A, MT53E2G32D4NQ-046 WT:C : SPD_SOURCES += spd/lp4x/set-0/spd-3.hex # ID = 3(0b0011) Parts = H9HCNNNCPMMLXR-NEE, MT53E1G32D2NP-046 WT:B : Remove
File src/mainboard/google/brox/variants/brox/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/78009/comment/f64659d0_8f212732 : PS8, Line 1: # SPDX-License-Identifier: GPL-2.0-or-later : # This is an auto-generated file. Do not edit!! : # Generated by: : # util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brox/variants/skolas/memory src/mainboard/google/brox/variants/skolas/memory/mem_parts_used.txt : : SPD_SOURCES = : SPD_SOURCES += spd/lp5/set-1/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B Please see and use https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
File src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/78009/comment/37003c61_47e237b6 : PS8, Line 1: # SPDX-License-Identifier: GPL-2.0-or-later : # This is an auto-generated file. Do not edit!! : # Generated by: : # util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brox/variants/skolas/memory src/mainboard/google/brox/variants/skolas/memory/mem_parts_used.txt : : DRAM Part Name ID to assign Please see and use https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
File src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt:
PS8: Please see and use https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...