Ben Chuang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45062 )
Change subject: drivers/genesyslogic/gl9755: Add driver for Genesys Logic GL9755
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45062/2/src/drivers/genesyslogic/gl...
File src/drivers/genesyslogic/gl9755/gl9755.h:
https://review.coreboot.org/c/coreboot/+/45062/2/src/drivers/genesyslogic/gl...
PS2, Line 5: #include <types.h>
not used. […]
It will be removed. Thanks.
Done.
https://review.coreboot.org/c/coreboot/+/45062/2/src/drivers/genesyslogic/gl...
PS2, Line 7: #define CFG 0x800
Please align the values using tabs. […]
Thanks.
I Will align the values using tabs.
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16048dde348be248c748d50ca4a8a62c8a781430
Gerrit-Change-Number: 45062
Gerrit-PatchSet: 2
Gerrit-Owner: Ben Chuang
benchuanggli@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Sep 2020 03:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment