Boon Tiong Teo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34166 )
Change subject: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
When I leave the blob default, I get prompted (in a different location non-obvious location) for CPU_MICROCODE_CBFS_LEN and CPU_MICROCODE_CBFS_LOC. Those have non-working default values (0). Resulting in a brick.
With a reasonable default here, the open-source NEM-enhanced, everything works fine.
We can make NEM-enhanced a default option then but in past IOTG folks wishes to make FSP-T usage for them. i believe default can be overriden so they can still use FSP-CAR if wishes.
That's what this change does.
And for the future (not for you Subrata but any interested reader): I've already tried to discuss this on Gerrit, I tried to discuss it via email, but IOTG is ignoring me and pushes crappy code rela- ted to FSP-T. If I ever run into issues with FSP-T again, I'll push a patch to remove its support for any platform where an open-source solution exists.
I guess lean sheng and BT is from IOTG should help to explain what all required to enable any flow. And its not expected that one needs to struggle to enable such feature. Hopefully IOT folks will take care in future.
Hi Nico, are you telling us that when you choose to use Fsp-Car, and with your config will pump into getting CPU_MICROCODE_CBFS_LEN and _LOC = 0? With that causing you having boot failure?