[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Drop ACPIMMIO bank for SMBus device PCI config

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42685 )

Change subject: soc/amd/common: Drop ACPIMMIO bank for SMBus device PCI config
......................................................................

Patch Set 8:

(1 comment)

File src/soc/amd/picasso/uart.c:

https://review.coreboot.org/c/coreboot/+/42685/comment/d77776a5_b0772aea 
PS8, Line 106: 	   generator divisor programming? 16*115200 = 1.8432M. */
> See previous comments exchanged with Raul; I could not tell what this does, but assumed it would aff […]

AFAICS one cannot currently select AMD_SOC_UART_1_8MZ anyways with psp_verstage since the register write cannot be done.

And if we added ENV_X86 we have the case of changing baudrate reference clock while UART is already configured. If there is some functionality/legacy support provided here, it's still obscure to me what it is.