Attention is currently required from: Michał Żygowski, Paul Menzel, Andrey Petrov, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52850 )
Change subject: drivers/intel/fsp2_0: Fix the FSP_T position
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/52850/comment/19ddf8ba_f96bb357
PS2, Line 81: The location for FSP-T.
This value should be also set per SoC. It may differ across FSP releases. FSP-T is not relocated by CBFS IIRC, at least in my case it did not land at the address in CBFS specified in FSP header.
I checked that this does get relocated by cbfstool on at least Coffeelake FSP and Cooperlake FSP. Do you have an example where this is not the case?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ec8b238384684dccf39e5da902d426d3a32b9db
Gerrit-Change-Number: 52850
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 03 May 2021 14:04:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment