Attention is currently required from: Martin L Roth, Martin Roth, Fred Reitberger.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68193 )
Change subject: util/amdfwtool: Add preliminary code for morgana & glinda SOCs
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/68193/comment/840fb5bf_cbc9df26
PS2, Line 1940: return PLATFORM_GLENDA;
Done
I'll likely make the same error many times.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68193
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I766ce4a5863c55cbc4bef074ac5219b498c48c7f
Gerrit-Change-Number: 68193
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 07 Oct 2022 21:49:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment