Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31235 )
Change subject: soc/intel: Fix for missing mem_rank info in SMBIOS
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/31235/5/3rdparty/blobs
File 3rdparty/blobs:
https://review.coreboot.org/#/c/31235/5/3rdparty/blobs@a1
PS5, Line 1:
The delete was intentional, it should not be in the patch as mentioned by one reviewer
No, you should not add or delete the submodules pointer as part of your CL. I meant remove this from your change. Sorry if I hadn't been clear before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I212215040e4786c258a9c604cc5c2bb62867c842
Gerrit-Change-Number: 31235
Gerrit-PatchSet: 10
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 13 Feb 2019 01:48:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-MessageType: comment