build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44632 )
Change subject: mb/google/volteer/variants/eldrid: add memory.c for ddr4 support
......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44632/10/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/eldrid/gpio.c:
https://review.coreboot.org/c/coreboot/+/44632/10/src/mainboard/google/volte...
PS10, Line 69: /* D4 : IMGCLKOUT0# ==> CAMMERA_SWITCH */
code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44632/10/src/mainboard/google/volte...
PS10, Line 70: PAD_CFG_GPI(GPP_D4, NONE, DEEP),
code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44632/10/src/mainboard/google/volte...
PS10, Line 70: PAD_CFG_GPI(GPP_D4, NONE, DEEP),
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44632
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c7b30093a8d85bac5aba5b83768af5eb36c4f70
Gerrit-Change-Number: 44632
Gerrit-PatchSet: 10
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Assignee: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.corp-partner.google.com
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 01 Sep 2020 09:06:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment