21 May
2024
21 May
'24
8:37 p.m.
Attention is currently required from: Brandon Weeks, Federico Amedeo Izzo, Felix Singer, Joel Linn, Paul Menzel.
Angel Pons has posted comments on this change by Brandon Weeks. ( https://review.coreboot.org/c/coreboot/+/81595?usp=email )
Change subject: mb/cwwk: Add CWWK CW-ADL-4L-V1.0 board ......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/cwwk/adl/Kconfig:
https://review.coreboot.org/c/coreboot/+/81595/comment/027541dc_b2249a75?usp... : PS10, Line 9: select HAVE_ACPI_RESUME If S3 isn't working, it might be a good idea to temporarily comment this out: ```suggestion #select HAVE_ACPI_RESUME # TODO: Uncomment once it works ```
--
To view, visit https://review.coreboot.org/c/coreboot/+/81595?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice9174d95c10afc6a22ddd15fb3be4fa38d329be
Gerrit-Change-Number: 81595
Gerrit-PatchSet: 10
Gerrit-Owner: Brandon Weeks bweeks@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Federico Amedeo Izzo federico@izzo.pro
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Joel Linn jl_coreboot@conductive.de
Gerrit-CC: Matthew Garrett mjgarrett59@googlemail.com
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Brandon Weeks bweeks@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Federico Amedeo Izzo federico@izzo.pro
Gerrit-Attention: Joel Linn jl_coreboot@conductive.de
Gerrit-Comment-Date: Tue, 21 May 2024 23:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No