Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44265 )
Change subject: ec/google/chromeec: Add dptc interface support ......................................................................
Patch Set 17:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44265/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44265/11//COMMIT_MSG@9 PS11, Line 9: add the dptc interface support when system in tablet mode
Can you please add some more context as to what platforms this interface is supposed to be used.
Done
https://review.coreboot.org/c/coreboot/+/44265/11//COMMIT_MSG@12 PS11, Line 12: none
zork
Done
https://review.coreboot.org/c/coreboot/+/44265/11/src/ec/google/chromeec/acp... File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/44265/11/src/ec/google/chromeec/acp... PS11, Line 13: #ifdef DPTC_SUPPORT_ENABLE
Can you please add a comment here indicating what platforms this method will be present/used on?
Done
https://review.coreboot.org/c/coreboot/+/44265/11/src/ec/google/chromeec/acp... PS11, Line 386: _SB.DPTC()
I think it would be safer to add a check to ensure that DPTC is really provided: […]
Done