29 Jan
2019
29 Jan
'19
11:20 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30834 )
Change subject: Documentation: Add coding style ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30834/2/Documentation/coding_style.md File Documentation/coding_style.md:
https://review.coreboot.org/#/c/30834/2/Documentation/coding_style.md@10 PS2, Line 10: First off, I'd suggest printing out a copy of the GNU coding standards, ?
https://review.coreboot.org/#/c/30834/2/Documentation/coding_style.md@420 PS2, Line 420: is exported, the EXPORT* macro for it should follow immediately after remove, there's no EXPORT_SYMBOL
--
To view, visit https://review.coreboot.org/c/coreboot/+/30834
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id56a8b7500121c4d9c18bc0b6bbc2c05402268dc
Gerrit-Change-Number: 30834
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Jan 2019 07:20:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment