Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45588 )
Change subject: spd: move weak mainboard_get_dram_part_num implementation to lib/spd_bin.c ......................................................................
Patch Set 18:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45588/18/src/include/memory_info.h File src/include/memory_info.h:
https://review.coreboot.org/c/coreboot/+/45588/18/src/include/memory_info.h@... PS18, Line 116: ength of string not including the null terminator I don't think that is correct. Looking at the implementation, len seems to return the length of string including '\0' terminator.
https://review.coreboot.org/c/coreboot/+/45588/18/src/include/memory_info.h@... PS18, Line 119: bool Can we use `const char *` as the return type for this function with expectation that: NULL = No part number override provided by mainboard non-NULL = Pointer to a string terminating in '\0' and whose length is returned in `len`.
I think it is easier to read and understand what the function does rather than the bool true/false.