Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39530 )
Change subject: soc/intel/Kconfig: Avoid specifying dedicated chipset name
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39530/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39530/3//COMMIT_MSG@13
PS3, Line 13: Rename: src/soc/intel/common/Kconfig to src/soc/intel/common/Kconfig.common
I do not see why the renaming is needed. Please elaborate why the renaming is needed.
Ack
https://review.coreboot.org/c/coreboot/+/39530/3//COMMIT_MSG@13
PS3, Line 13: Rename: src/soc/intel/common/Kconfig to src/soc/intel/common/Kconfig.common
: Change: All specific SoC sources to "source src/soc/intel/*/Kconfig"
: Change: Common source to "source src/soc/intel/common/Kconfig.common"
These prefixes (Rename, Change) look quite strange. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39530
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2d8a8ac1c4acfabd4ded1bfd4ff359e820e174b
Gerrit-Change-Number: 39530
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 14 Mar 2020 16:58:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment