Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48233 )
Change subject: soc/mediatek/mt8183/sspm.c: Use mtlib_init_mcu API
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48233/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48233/4//COMMIT_MSG@6
PS4, Line 6:
: soc/mediatek/mt8183/sspm.c: Use mtlib_init_mcu API
nit: rename this to
soc/mediatek/mt8183: Use mtlib_init_mcu to init SSPM
https://review.coreboot.org/c/coreboot/+/48233/4//COMMIT_MSG@10
PS4, Line 10: TEST=emerge-kukui coreboot
Add a blank line before TEST=
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63c4b99342bdebb2a94cbf0c6380b0a6817853e7
Gerrit-Change-Number: 48233
Gerrit-PatchSet: 4
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Dec 2020 09:02:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment