Attention is currently required from: Eric Lai, Paul Menzel, Subrata Banik.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ......................................................................
Patch Set 11:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81773/comment/4a8f7207_7dd4dc4f : PS9, Line 9: Add RT5645 AMP support.
Please elaborate. […]
cbj-sleeve-gpios was only added on rt5645.
https://review.coreboot.org/c/coreboot/+/81773/comment/6bb47d74_f2dc4f5a : PS9, Line 12: Realtek upstream link:(https://lore.kernel.org/all/20240404035747.118064-1-derek.fang@realtek.com/)
Please put the URL on a separate line without brackets.
Done
https://review.coreboot.org/c/coreboot/+/81773/comment/d38bf14c_2c5175fc : PS9, Line 15: TEST=RT5645 driver can probe properly.
Please name the device, and paste the relevant log messages.
Done
File src/drivers/i2c/rt5645/rt5645.c:
https://review.coreboot.org/c/coreboot/+/81773/comment/0a0c18d7_7047d115 : PS9, Line 11: #define RT5645_DP_INT(key, val) \
no need macro if just use ones
I am not sure whether other modes will be added in the future, so we reserve this macro.