Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48557 )
Change subject: tests: Add lib/fmap-test test case ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48557/3/tests/lib/fmap-test.c File tests/lib/fmap-test.c:
https://review.coreboot.org/c/coreboot/+/48557/3/tests/lib/fmap-test.c@118 PS3, Line 118: /* assert_int_equal(-1, fmap_locate_area_as_rdev("RW_SECTION_A", NULL)); : * : * It is not allowed to pass NULL as region_device pointer. : */ Please remove the commented-out code. If needed, keep a comment that you're not testing a NULL pointer because it's not allowed, but don't have a complete line of code commented out.
https://review.coreboot.org/c/coreboot/+/48557/3/tests/lib/fmap-test.c@153 PS3, Line 153: /* assert_int_equal(-1, fmap_locate_area_as_rdev_rw("RW_SECTION_A", NULL)); Same comment here - remove unused code instead of commenting it out.
https://review.coreboot.org/c/coreboot/+/48557/3/tests/lib/fmap-test.c@232 PS3, Line 232: /* assert_int_equal(-1, fmap_read_area("RW_SECTION_A", NULL, section_size)); Remove unused code instead of commenting out