Hello Sathyanarayana Nujella, build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Duncan Laurie, Paul Fagerburg, Angel Pons, Nick Vaccaro, Srinidhi N Kaushik, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44560
to look at the new patch set (#6).
Change subject: mb/google/volteer: Add firmware configuration for MAX98373_ALC5682I_I2S_UP4
......................................................................
mb/google/volteer: Add firmware configuration for MAX98373_ALC5682I_I2S_UP4
Add MAX98373_ALC5682I_I2S_UP4 firmware configuration option and configure GPIOs properly for UP4 design. The design is also for Halvor.
BUG=b:153680359, b:163382106
TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage, fw_config value in Halvor:
AUDIO=MAX98373_ALC5682I_I2S_UP4
ectool cbi set 6 0x00000400 4 2
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com
Change-Id: Ie25f278dfbdc2f41a36b70403699a2e3c2234600
---
M src/mainboard/google/volteer/fw_config.c
M src/mainboard/google/volteer/variants/baseboard/devicetree.cb
2 files changed, 19 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/44560/6
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44560
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie25f278dfbdc2f41a36b70403699a2e3c2234600
Gerrit-Change-Number: 44560
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Kevin Cheng
kevin.cheng@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: newpatchset