Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Paul Menzel.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56750 )
Change subject: wifi: Add support for new revisions of SAR table entries
......................................................................
Patch Set 25: Code-Review+1
(3 comments)
File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/56750/comment/220b3f9b_dd2636b1
PS25, Line 59: (1 + sar->dsar_set_count)
comment why the `1 + ` is required?
https://review.coreboot.org/c/coreboot/+/56750/comment/2ba395c1_d52165bb
PS25, Line 99: void *
a `uint8_t *` should be able to cast to anything, this can be:
`struct sar_header *`
https://review.coreboot.org/c/coreboot/+/56750/comment/afbe0e3e_26ead37e
PS25, Line 220: !strncmp(sar_str, SAR_STR_PREFIX, SAR_STR_PREFIX_SIZE) != 0
extra `!` at the beginning
`if (strncmp(sar_str, SAR_STR_PREFIX, SAR_STR_PREFIX_SIZE) != 0)`
?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56750
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c3f321938eba04e8bcff4d87cb215422715bb2
Gerrit-Change-Number: 56750
Gerrit-PatchSet: 25
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie.chen@intel.com
Gerrit-CC: Janiex Tu
janiex.tu@intel.corp-partner.google.com
Gerrit-CC: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 01 Sep 2021 21:00:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment