Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30939 )
Change subject: nb/intel/pineview: Move to C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/30939/5/src/southbridge/intel/i82801gx/bootb...
File src/southbridge/intel/i82801gx/bootblock_gcc.c:
https://review.coreboot.org/#/c/30939/5/src/southbridge/intel/i82801gx/bootb...
PS5, Line 27: reg8 = pci_read_config8(dev, 0xdc);
BIOS_CNTL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e74838b0d5e9c192082084cfd9821996f0e4c50
Gerrit-Change-Number: 30939
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 12 May 2019 10:10:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment