Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48074 )
Change subject: spi/flashconsole: Fix internal buffer overflow
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48074/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48074/1//COMMIT_MSG@9
PS1, Line 9: Once the console's FMAP region is full, we stop clearing the line
: buffer and `line_offset` is not reset anymore
Maybe mention the problem too: […]
We could add that to any problem that results in undefined behavior...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48074
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36e9037d7baf8c1ed8b2d0c120bfffa58c089c95
Gerrit-Change-Number: 48074
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 03 Dec 2020 23:26:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment