Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33775 )
Change subject: soc/{amd, intel}: Increase size of postcar stack
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33775/2/src/include/memlayout.h
File src/include/memlayout.h:
https://review.coreboot.org/#/c/33775/2/src/include/memlayout.h@45
PS2, Line 45: #ifndef POSTCAR_COMMON_RAM_STACK_SIZE
The original argumentation when this stack was reduced to 1 KiB was about LZMA scrathpad having bein […]
What specific place would we add the decoration? Is that in vboot itself? Eating 4KiB might be the easier and more straight forward approach.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba1fb5bfad6946f316feac2d8c998a782142a56a
Gerrit-Change-Number: 33775
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Thu, 27 Jun 2019 15:41:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment