Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33652 )
Change subject: arch/x86/acpi: Add os.asl ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl File src/arch/x86/acpi/os.asl:
https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl@77 PS1, Line 77: }
missing _OSI Strings for […]
I'm starting to get with Angel Pons and I might either change this to be used only with platforms that will use some version of windows (not sure if anyone uses coreboot with windows) or completely abandon it. If I go the first option, I'll take your advice into consideration. Anyway, I have to change 33620 to NOT USE this patch before I do anything else with this patch.
https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl@84 PS1, Line 84: Zero
Yes, Zero and One are the same as 0x00 and 0x01, but the latter are more consistent with the rest of […]
If I decide to keep this code I'll implement the change for consistency.
https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl@94 PS1, Line 94: If(SCPM(local0, "Linux"))
Right. […]
Ugh... almost going for abandoning this patch.