Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37358 )
Change subject: src/: Remove g_ prefixes and _g suffixes from variables ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37358/1/src/cpu/intel/common/fsb.c File src/cpu/intel/common/fsb.c:
https://review.coreboot.org/c/coreboot/+/37358/1/src/cpu/intel/common/fsb.c@... PS1, Line 102: car_set_var(timer_fsb, fsb);
Are these accessors still needed?
There's a commit by Arthur to sort these out, and once that goes in, this commit will be updated.
https://review.coreboot.org/c/coreboot/+/37358/1/src/drivers/elog/elog.c File src/drivers/elog/elog.c:
https://review.coreboot.org/c/coreboot/+/37358/1/src/drivers/elog/elog.c@97 PS1, Line 97: elog_state.mirror_last_write);
Spurious line break?
I'll need to check if coccinelle has a 80 column limit somewhere that I should override.
https://review.coreboot.org/c/coreboot/+/37358/1/src/drivers/elog/elog.c@804 PS1, Line 804: elog_size);
This one seems spurious as well
Ack